[clang-tools-extra] [clang-tidy] Create bugprone-public-enable-shared-from-this check (PR #102299)

Piotr Zegar via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 7 04:32:11 PDT 2024


================
@@ -139,6 +140,8 @@ class BugproneModule : public ClangTidyModule {
         "bugprone-inaccurate-erase");
     CheckFactories.registerCheck<IncorrectEnableIfCheck>(
         "bugprone-incorrect-enable-if");
+    CheckFactories.registerCheck<PublicEnableSharedFromThisCheck>(
+        "bugprone-public-enable-shared-from-this");
----------------
PiotrZSL wrote:

name should be more a "non-public", as check should tell whats wrong.
i would call this check bugprone-incorrect-enable-shared-from-this, and then you could also check other constructions in future like:
```
class Bad2Example : enable_shared_from_this<BadExample> {};
```

https://github.com/llvm/llvm-project/pull/102299


More information about the cfe-commits mailing list