[clang] [libclang/python] Fix some type errors, add type annotations (PR #98745)

Vlad Serebrennikov via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 6 04:05:53 PDT 2024


================
@@ -64,48 +64,80 @@
 
 from ctypes import *
 
-import collections.abc
 import os
+import sys
 from enum import Enum
 
+from typing import (
+    Any,
+    Callable,
+    Generic,
+    Optional,
+    Type as TType,
+    TypeVar,
+    TYPE_CHECKING,
+    Union as TUnion,
+)
+
+if TYPE_CHECKING:
+    from ctypes import _Pointer
+    from typing_extensions import Protocol, TypeAlias
----------------
Endilll wrote:

Sure, this is not going to affect normal usage. But I still wonder how it's handled in the ecosystem when `TYPE_CHECKING` mode brings additional dependencies. If `typing_extensions` are generally assumed to be available in this mode, then I'm fine with it.

https://github.com/llvm/llvm-project/pull/98745


More information about the cfe-commits mailing list