[clang] [CodeGen][NFCI] Don't re-implement parts of ASTContext::getIntWidth (PR #101765)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 2 15:32:10 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-codegen
Author: Jessica Clarke (jrtc27)
<details>
<summary>Changes</summary>
ASTContext::getIntWidth returns 1 if isBooleanType(), and falls back on
getTypeSize in the default case, which itself just returns the Width
from getTypeInfo's returned struct, so can be used in all cases here,
not just for _BitInt types.
---
Full diff: https://github.com/llvm/llvm-project/pull/101765.diff
1 Files Affected:
- (modified) clang/lib/CodeGen/CGBuiltin.cpp (+1-3)
``````````diff
diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp
index 3221989e14351..a0140b81925d1 100644
--- a/clang/lib/CodeGen/CGBuiltin.cpp
+++ b/clang/lib/CodeGen/CGBuiltin.cpp
@@ -756,9 +756,7 @@ static WidthAndSignedness
getIntegerWidthAndSignedness(const clang::ASTContext &context,
const clang::QualType Type) {
assert(Type->isIntegerType() && "Given type is not an integer.");
- unsigned Width = Type->isBooleanType() ? 1
- : Type->isBitIntType() ? context.getIntWidth(Type)
- : context.getTypeInfo(Type).Width;
+ unsigned Width = context.getIntWidth(Type);
bool Signed = Type->isSignedIntegerType();
return {Width, Signed};
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/101765
More information about the cfe-commits
mailing list