[clang] [Modules][Diagnostic] Mention which AST file's options differ from the current TU options. (PR #101413)

Chuanqi Xu via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 1 19:53:32 PDT 2024


================
@@ -130,7 +130,7 @@ class ASTReaderListener {
   ///
   /// \returns true to indicate the options are invalid or false otherwise.
   virtual bool ReadLanguageOptions(const LangOptions &LangOpts,
-                                   bool Complain,
+                                   StringRef Filename, bool Complain,
----------------
ChuanqiXu9 wrote:

Let's add a comment to explain the meaning of `Filename`. It is not clear from the signature. Or we can rename the parameter to make it claer.

https://github.com/llvm/llvm-project/pull/101413


More information about the cfe-commits mailing list