[clang] [HLSL] Change default linkage of HLSL functions and groupshared variables (v2) (PR #95331)
Helena Kotas via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 1 14:16:55 PDT 2024
================
@@ -1,5 +1,8 @@
// RUN: %clang_cc1 -triple dxil-unknown-shadermodel6.6-library -S -fnative-half-type -finclude-default-header -o - -ast-dump %s | FileCheck %s
// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -o - | FileCheck %s --check-prefixes=CHECKIR
+
+export {
----------------
hekota wrote:
Marking the individual functions as `export` or using the big `export` block around the file is equivalent. I don't think the inconsistent use in the test is an issue. Each test author can pick a style that works best for each test. If there is just a single or a couple of functions it seems easier to mark each function, and if there are more then an `export` block makes more sense. Another option is to include a shader point function that calls all the other functions to make sure the code gets generated.
Unlike DXC we do not yet have a command line option to change the default linkage ([hlsl-specs/issues#242](https://github.com/microsoft/hlsl-specs/issues/242)) and I don't think Clang's `-fvisibility` applies here.
https://github.com/llvm/llvm-project/pull/95331
More information about the cfe-commits
mailing list