[clang] [clang] fix classification of a string literal expression used as initializer (PR #101447)

Thu Aug 1 12:48:38 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/3064

Here is the relevant piece of the build log for the reference:
```
Step 5 (compile-openmp) failure: build (failure)
...
0.252 [344/34/140] Building CXX object libc/src/stdbit/CMakeFiles/libc.src.stdbit.stdc_has_single_bit_ui.dir/stdc_has_single_bit_ui.cpp.o
0.254 [343/34/141] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.fabs.dir/fabs.cpp.o
0.265 [342/34/142] Building CXX object libc/src/stdbit/CMakeFiles/libc.src.stdbit.stdc_bit_width_us.dir/stdc_bit_width_us.cpp.o
0.265 [341/34/143] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.fabsf.dir/fabsf.cpp.o
0.265 [340/34/144] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.fmaf.dir/fmaf.cpp.o
0.265 [339/34/145] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.fmaxf.dir/fmaxf.cpp.o
0.266 [338/34/146] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.fmin.dir/fmin.cpp.o
0.266 [337/34/147] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.fminf.dir/fminf.cpp.o
0.266 [336/34/148] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.fmodf.dir/fmodf.cpp.o
0.267 [335/34/149] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strcpy.dir/strcpy.cpp.o
FAILED: libc/src/string/CMakeFiles/libc.src.string.strcpy.dir/strcpy.cpp.o 
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/clang++ --target=amdgcn-amd-amdhsa -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -I/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc -isystem /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/include/amdgcn-amd-amdhsa -O3 -DNDEBUG --target=amdgcn-amd-amdhsa -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -fpie -DLIBC_FULL_BUILD -nostdlibinc -ffixed-point -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors "-DLIBC_MATH=(LIBC_MATH_SKIP_ACCURATE_PASS | LIBC_MATH_SMALL_TABLES | LIBC_MATH_NO_ERRNO | LIBC_MATH_NO_EXCEPT)" -nogpulib -fvisibility=hidden -fconvergent-functions -flto -Wno-multi-gpu -Xclang -mcode-object-version=none -DLIBC_COPT_PUBLIC_PACKAGING -UNDEBUG -MD -MT libc/src/string/CMakeFiles/libc.src.string.strcpy.dir/strcpy.cpp.o -MF libc/src/string/CMakeFiles/libc.src.string.strcpy.dir/strcpy.cpp.o.d -o libc/src/string/CMakeFiles/libc.src.string.strcpy.dir/strcpy.cpp.o -c /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/string/strcpy.cpp
In file included from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/string/strcpy.cpp:9:
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/string/strcpy.h:13:10: fatal error: 'string.h' file not found
   13 | #include <string.h>
      |          ^~~~~~~~~~
1 error generated.
0.267 [335/33/150] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.fmod.dir/fmod.cpp.o
0.267 [335/32/151] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.nearbyint.dir/nearbyint.cpp.o
0.267 [335/31/152] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.nearbyintf.dir/nearbyintf.cpp.o
0.267 [335/30/153] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.remainderf.dir/remainderf.cpp.o
0.269 [335/29/154] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strdup.dir/strdup.cpp.o
FAILED: libc/src/string/CMakeFiles/libc.src.string.strdup.dir/strdup.cpp.o 
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/clang++ --target=amdgcn-amd-amdhsa -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -I/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc -isystem /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/include/amdgcn-amd-amdhsa -O3 -DNDEBUG --target=amdgcn-amd-amdhsa -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -fpie -DLIBC_FULL_BUILD -nostdlibinc -ffixed-point -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors "-DLIBC_MATH=(LIBC_MATH_SKIP_ACCURATE_PASS | LIBC_MATH_SMALL_TABLES | LIBC_MATH_NO_ERRNO | LIBC_MATH_NO_EXCEPT)" -nogpulib -fvisibility=hidden -fconvergent-functions -flto -Wno-multi-gpu -Xclang -mcode-object-version=none -DLIBC_COPT_PUBLIC_PACKAGING -UNDEBUG -MD -MT libc/src/string/CMakeFiles/libc.src.string.strdup.dir/strdup.cpp.o -MF libc/src/string/CMakeFiles/libc.src.string.strdup.dir/strdup.cpp.o.d -o libc/src/string/CMakeFiles/libc.src.string.strdup.dir/strdup.cpp.o -c /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/string/strdup.cpp
In file included from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/string/strdup.cpp:9:
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/libc/src/string/strdup.h:13:10: fatal error: 'string.h' file not found
   13 | #include <string.h>
      |          ^~~~~~~~~~
1 error generated.
0.276 [335/28/155] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.rint.dir/rint.cpp.o
0.277 [335/27/156] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.round.dir/round.cpp.o
0.277 [335/26/157] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.rintf.dir/rintf.cpp.o
0.278 [335/25/158] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.sqrtf.dir/sqrtf.cpp.o
0.279 [335/24/159] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.remainder.dir/remainder.cpp.o
0.279 [335/23/160] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.trunc.dir/trunc.cpp.o
0.281 [335/22/161] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strcasestr.dir/strcasestr.cpp.o
0.282 [335/21/162] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.sqrt.dir/sqrt.cpp.o
0.290 [335/20/163] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.fmax.dir/fmax.cpp.o
0.291 [335/19/164] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.frexp.dir/frexp.cpp.o
0.292 [335/18/165] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.truncf.dir/truncf.cpp.o
0.292 [335/17/166] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.scalbnf.dir/scalbnf.cpp.o
0.293 [335/16/167] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.ldexp.dir/ldexp.cpp.o
0.295 [335/15/168] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.scalbn.dir/scalbn.cpp.o
0.297 [335/14/169] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.acos.dir/acos.cpp.o
0.299 [335/13/170] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.frexpf.dir/frexpf.cpp.o
0.299 [335/12/171] Building CXX object libc/src/math/amdgpu/CMakeFiles/libc.src.math.amdgpu.ldexpf.dir/ldexpf.cpp.o
0.314 [335/11/172] Building CXX object libc/src/inttypes/CMakeFiles/libc.src.inttypes.strtoumax.dir/strtoumax.cpp.o
0.314 [335/10/173] Building CXX object libc/src/string/CMakeFiles/libc.src.string.strcspn.dir/strcspn.cpp.o
0.319 [335/9/174] Building CXX object libc/src/inttypes/CMakeFiles/libc.src.inttypes.strtoimax.dir/strtoimax.cpp.o

```

https://github.com/llvm/llvm-project/pull/101447