[clang] [HLSL] Change default linkage of HLSL functions and groupshared variables (v2) (PR #95331)

Damyan Pepper via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 1 11:23:32 PDT 2024


================
@@ -1,5 +1,8 @@
 // RUN: %clang_cc1 -triple dxil-unknown-shadermodel6.6-library -S -fnative-half-type -finclude-default-header -o - -ast-dump %s | FileCheck %s
 // RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -o - | FileCheck %s --check-prefixes=CHECKIR
+
+export {
----------------
damyanp wrote:

So I think there was a choice here between marking each individual function as `export` or using the big block around the file.  I think there may also be a third option involving a command-line parameter?

Anyway, I think we're ending up now with the tests being inconsistent - there's some individually marked and there's some marked with the bock. I think the choice was mainly made to save typing? Are we confident it's the right one?

https://github.com/llvm/llvm-project/pull/95331


More information about the cfe-commits mailing list