https://github.com/AaronBallman approved this pull request. LGTM (modulo whitespace nits), but please make sure the 19.x branch gets a release note officially deprecating the trait and saying it will be removed in Clang 20. https://github.com/llvm/llvm-project/pull/99038