[clang] [clang-format] Rename variable more sensitively (PR #100943)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Jul 28 11:02:54 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-format
Author: Nathan Sidwell (urnathan)
<details>
<summary>Changes</summary>
I noticed the insensitively named `Blacklist` variable when looking at https://github.com/llvm/llvm-project/pull/100852. Let's renaming to `Disallowed`.
---
Full diff: https://github.com/llvm/llvm-project/pull/100943.diff
1 Files Affected:
- (modified) clang/lib/Format/UnwrappedLineParser.cpp (+2-2)
``````````diff
diff --git a/clang/lib/Format/UnwrappedLineParser.cpp b/clang/lib/Format/UnwrappedLineParser.cpp
index d406a531a5c0c..ed056b9dd5b75 100644
--- a/clang/lib/Format/UnwrappedLineParser.cpp
+++ b/clang/lib/Format/UnwrappedLineParser.cpp
@@ -2554,7 +2554,7 @@ bool UnwrappedLineParser::parseParens(TokenType AmpAmpTokenType) {
const bool DoubleParens =
Prev && Prev->is(tok::l_paren) && Next && Next->is(tok::r_paren);
const auto *PrevPrev = Prev ? Prev->getPreviousNonComment() : nullptr;
- const bool Blacklisted =
+ const bool Disallowed =
PrevPrev &&
(PrevPrev->isOneOf(tok::kw___attribute, tok::kw_decltype) ||
(SeenEqual &&
@@ -2566,7 +2566,7 @@ bool UnwrappedLineParser::parseParens(TokenType AmpAmpTokenType) {
(!NestedLambdas.empty() && !NestedLambdas.back())) &&
Prev && Prev->isOneOf(tok::kw_return, tok::kw_co_return) && Next &&
Next->is(tok::semi);
- if ((DoubleParens && !Blacklisted) || ReturnParens) {
+ if ((DoubleParens && !Disallowed) || ReturnParens) {
LeftParen->Optional = true;
FormatTok->Optional = true;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/100943
More information about the cfe-commits
mailing list