[clang] [Clang][AST] {CXXDefaultArgExpr, CXXDefaultInitExpr}::hasRewrittenInit return true iff the init expression was really rebuild (PR #99748)

Shafik Yaghmour via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 26 14:43:51 PDT 2024


================
@@ -1579,11 +1579,11 @@ void JSONNodeDumper::VisitMaterializeTemporaryExpr(
 }
 
 void JSONNodeDumper::VisitCXXDefaultArgExpr(const CXXDefaultArgExpr *Node) {
-  attributeOnlyIfTrue("hasRewrittenInit", Node->hasRewrittenInit());
+  JOS.attribute("hasRewrittenInit", Node->hasRewrittenInit());
----------------
shafik wrote:

So if IIUC this used to only write the attribute if the value was `true`, so we should have a test for both cases `true` and `false` to verify this is working as intended.

https://github.com/llvm/llvm-project/pull/99748


More information about the cfe-commits mailing list