[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

[via cfe-commits]

================
@@ -873,30 +873,17 @@ class Sema final : public SemaBase {
   /// Warn when implicitly casting 0 to nullptr.
   void diagnoseZeroToNullptrConversion(CastKind Kind, const Expr *E);
 
-  // ----- function effects ---
+  /// All functions/lambdas/blocks which have bodies and which have a non-empty
+  /// FunctionEffectsRef to be verified.
+  SmallVector<const Decl *> DeclsWithEffectsToVerify;
+  /// The union of all effects present on DeclsWithEffectsToVerify. Conditions
+  /// are all null.
+  FunctionEffectSet AllEffectsToVerify;
----------------
Sirraide wrote:

> Well, the large codebases I've adapted care deeply about nonblocking and do not use nonallocating.

I see, in that case, if there is a use case for it, then we can also just keep this if it makes things easier (or lets us do less work); I don’t feel too strongly about that in that case.

https://github.com/llvm/llvm-project/pull/99656