[clang-tools-extra] Create a new check to look for mis-use in calls that take iterators (PR #99917)

[Julian Schmidt via cfe-commits]

================
@@ -0,0 +1,122 @@
+.. title:: clang-tidy - bugprone-incorrect-iterators
+
+bugprone-incorrect-iterators
+============================
+
+Detects calls to iterator algorithms where they are called with potentially
+invalid arguments.
+
+Different ranges
+================
+
+Looks for calls where the range for the ``begin`` argument is different to the
+``end`` argument.
+
+.. code-block:: c++
+
+  std::find(a.begin(), b.end(), 0);
+  std::find(std::begin(a), std::end(b));
+
+Mismatched Begin/end
----------------
5chmidti wrote:

I'd use `End`, as it is in a caption

https://github.com/llvm/llvm-project/pull/99917