[clang-tools-extra] Fix crash in modernize-use-ranges (PR #100427)

Piotr Zegar via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 24 13:00:12 PDT 2024


================
@@ -123,32 +108,34 @@ makeMatcherPair(StringRef State, const UseRangesCheck::Indexes &Indexes,
 }
 
 void UseRangesCheck::registerMatchers(MatchFinder *Finder) {
-  Replaces = getReplacerMap();
+  auto Replaces = getReplacerMap();
   ReverseDescriptor = getReverseDescriptor();
   auto BeginEndNames = getFreeBeginEndMethods();
   llvm::SmallVector<StringRef, 4> BeginNames{
       llvm::make_first_range(BeginEndNames)};
   llvm::SmallVector<StringRef, 4> EndNames{
       llvm::make_second_range(BeginEndNames)};
-  llvm::DenseSet<ArrayRef<Signature>> Seen;
+  Replacers.clear();
----------------
PiotrZSL wrote:

Note: that Replaces vs Replacers is confusing, consider changing a name of one later on main.

https://github.com/llvm/llvm-project/pull/100427


More information about the cfe-commits mailing list