[clang] [clang][dataflow] Handle CXXInheritedCtorInitExpr in ResultObjectVisitor. (PR #99616)
Artem Dergachev via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 24 12:17:25 PDT 2024
haoNoQ wrote:
I have a high-level question not directly related to the patch. We have probably even talked about it at a conference a few years ago but I don't remember 😅
> `ResultObjectVisitor`
I briefly looked at the implementation and I suspect that you folks might be reinventing [`ConstructionContext`](https://clang.llvm.org/doxygen/classclang_1_1ConstructionContext.html) which is typically¹ already available in the CFG. (Under an off-by-default CFG build option.) (I'm in favor of turning it on by default.) (Together with a few other options that improve precision, eg. copy elision and RVO support.)
__
¹ Not all of the 30+ possible construction contexts are currently implemented. But your visitor doesn't seem to implement them either.
https://github.com/llvm/llvm-project/pull/99616
More information about the cfe-commits
mailing list