[clang] [clang] Update argument checking tablegen code to use a 'full' name (PR #99993)
Justin Bogner via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 23 09:56:06 PDT 2024
================
@@ -191,6 +191,12 @@ class AttributeCommonInfo {
/// __gnu__::__attr__ will be normalized to gnu::attr).
std::string getNormalizedFullName() const;
+ /// Gets a normalized full name, with syntax, scope and name.
+ static std::string
+ getNormalizedFullNameWithSyntax(const IdentifierInfo *Name,
+ const IdentifierInfo *Scope,
+ AttributeCommonInfo::Syntax SyntaxUsed);
----------------
bogner wrote:
It feels inconsistent to have a member function `getX` and a static member `getXWithY`. Might be better to spell this with `normalize` as the verb, like `normalizeFullNameWithSyntax`
https://github.com/llvm/llvm-project/pull/99993
More information about the cfe-commits
mailing list