[clang] [clang] replaced the usage of `asctime` with `strftime` (PR #99075)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 22 11:21:27 PDT 2024


================
@@ -1721,11 +1721,13 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) {
     Diag(Tok.getLocation(), diag::warn_pp_date_time);
     // MSVC, ICC, GCC, VisualAge C++ extension.  The generated string should be
     // of the form "Ddd Mmm dd hh::mm::ss yyyy", which is returned by asctime.
-    const char *Result;
+    const char *Result = "??? ??? ?? ??:??:?? ????";
+    char TimeString[64];
     if (getPreprocessorOpts().SourceDateEpoch) {
       time_t TT = *getPreprocessorOpts().SourceDateEpoch;
       std::tm *TM = std::gmtime(&TT);
-      Result = asctime(TM);
+      if (strftime(TimeString, sizeof TimeString, "%a %b %e %T %Y", TM) != 0)
----------------
AaronBallman wrote:

Ah, okay, thanks! Hmm, if we have to mess with locales either way, this seems reasonable to me.

https://github.com/llvm/llvm-project/pull/99075


More information about the cfe-commits mailing list