[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

Brad Smith via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 21 23:18:33 PDT 2024


https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/74025

>From bfee80b825aeb5c99f23149a2c4317eda10c1cd4 Mon Sep 17 00:00:00 2001
From: Brad Smith <brad at comstyle.com>
Date: Thu, 30 Nov 2023 20:50:01 -0500
Subject: [PATCH] [Clang] Remove NetBSD/i386 workaround for FP eval method with
 older versions

NetBSD 6.x is long EoL. Make 7.x the minimum and even that is EoL.
---
 clang/docs/ReleaseNotes.rst   | 5 +++++
 clang/lib/Basic/Targets/X86.h | 9 ---------
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 4ab6bd9de8ea9..54699453dcbc8 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -1239,6 +1239,11 @@ AIX Support
   This access sequence is not used for TLS variables larger than 32KB, and is
   currently only supported on 64-bit mode.
 
+NetBSD Support
+^^^^^^^^^^^^^^
+
+- Removed support for building binaries for NetBSD 6.x or older.
+
 WebAssembly Support
 ^^^^^^^^^^^^^^^^^^^
 
diff --git a/clang/lib/Basic/Targets/X86.h b/clang/lib/Basic/Targets/X86.h
index cdec41afd1a4b..ba34ab2c7f336 100644
--- a/clang/lib/Basic/Targets/X86.h
+++ b/clang/lib/Basic/Targets/X86.h
@@ -513,15 +513,6 @@ class LLVM_LIBRARY_VISIBILITY NetBSDI386TargetInfo
 public:
   NetBSDI386TargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
       : NetBSDTargetInfo<X86_32TargetInfo>(Triple, Opts) {}
-
-  LangOptions::FPEvalMethodKind getFPEvalMethod() const override {
-    VersionTuple OsVersion = getTriple().getOSVersion();
-    // New NetBSD uses the default rounding mode.
-    if (OsVersion >= VersionTuple(6, 99, 26) || OsVersion.getMajor() == 0)
-      return X86_32TargetInfo::getFPEvalMethod();
-    // NetBSD before 6.99.26 defaults to "double" rounding.
-    return LangOptions::FPEvalMethodKind::FEM_Double;
-  }
 };
 
 class LLVM_LIBRARY_VISIBILITY OpenBSDI386TargetInfo



More information about the cfe-commits mailing list