[clang] [PAC] Implement authentication for C++ member function pointers (PR #99576)

Daniil Kovalev via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 21 16:40:34 PDT 2024


================
@@ -3417,11 +3417,13 @@ uint16_t ASTContext::getPointerAuthTypeDiscriminator(QualType T) const {
   if (T->isFunctionPointerType() || T->isFunctionReferenceType())
     T = T->getPointeeType();
 
-  if (T->isFunctionType())
+  if (T->isFunctionType()) {
     encodeTypeForFunctionPointerAuth(*this, Out, T);
-  else
-    llvm_unreachable(
-        "type discrimination of non-function type not implemented yet");
+  } else {
----------------
kovdan01 wrote:

What can go here except member functions? Can we add assertions or smth checking a closed list of allowed type kinds here, or every type can potentially go here?

Feel free to ignore.

https://github.com/llvm/llvm-project/pull/99576


More information about the cfe-commits mailing list