[clang] Diag mismatch 97878 (PR #99824)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Jul 21 12:38:53 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Braden Helmer (bradenhelmer)
<details>
<summary>Changes</summary>
Fixes #<!-- -->97878
---
Full diff: https://github.com/llvm/llvm-project/pull/99824.diff
2 Files Affected:
- (modified) clang/lib/Sema/SemaOverload.cpp (+1-1)
- (modified) clang/test/SemaCXX/cxx2b-deducing-this.cpp (+8)
``````````diff
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index a8d250fbabfed..ac90ccd5643c1 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -11149,7 +11149,7 @@ static void DiagnoseBadConversion(Sema &S, OverloadCandidate *Cand,
if (isa<CXXMethodDecl>(Fn) && !isa<CXXConstructorDecl>(Fn)) {
if (I == 0)
isObjectArgument = true;
- else
+ else if (!Fn->hasCXXExplicitFunctionObjectParameter())
I--;
}
diff --git a/clang/test/SemaCXX/cxx2b-deducing-this.cpp b/clang/test/SemaCXX/cxx2b-deducing-this.cpp
index 5cbc1f735383b..6ad54b9b2c63d 100644
--- a/clang/test/SemaCXX/cxx2b-deducing-this.cpp
+++ b/clang/test/SemaCXX/cxx2b-deducing-this.cpp
@@ -959,3 +959,11 @@ void f();
};
void a::f(this auto) {} // expected-error {{an explicit object parameter cannot appear in a non-member function}}
}
+
+struct R {
+ void f(this auto &&self, int &&r_value_ref) {} // expected-note {{candidate function template not viable: expects an rvalue for 2nd argument}}
+ void g(int &&r_value_ref) {
+ f(r_value_ref); // expected-error {{no matching member function for call to 'f'}}
+ }
+};
+
``````````
</details>
https://github.com/llvm/llvm-project/pull/99824
More information about the cfe-commits
mailing list