[clang-tools-extra] [clang-tidy] Add modernize-use-cpp-style-comments check (PR #99713)

Carlos Galvez via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 20 03:54:59 PDT 2024


https://github.com/carlosgalvezp requested changes to this pull request.

Good check idea! A couple of comments:

- This is not really a "modernize"check. Both styles are equally valid and it's a matter of taste. Modernize is typically for checks that bump from one standard to a newer one.

- Instead I think this check fits better in "readability".

- I think we can take the opportunity and make the check scope slightly more general, so that it enforces ether C style comments or C++ style comments. So the check could be called "readability-comment-style". Right now you can support only C->C++ conversion but can be extended in the future to do the opposite.

https://github.com/llvm/llvm-project/pull/99713


More information about the cfe-commits mailing list