[clang] [PAC] Incorrect codegen for constant global init with polymorphic MI (PR #99741)

via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 19 22:57:43 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff a96c906102e8d0284c7a402eac4fa1ad9ab3e871 5822eb8f5b0d420a89d539f8fd2e23c69983967a --extensions cpp -- clang/test/CodeGenCXX/ptrauth-global-constant-initializers.cpp clang/lib/CodeGen/CGExprConstant.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/CodeGen/CGExprConstant.cpp b/clang/lib/CodeGen/CGExprConstant.cpp
index 3c6a522004..f22321f0e7 100644
--- a/clang/lib/CodeGen/CGExprConstant.cpp
+++ b/clang/lib/CodeGen/CGExprConstant.cpp
@@ -814,8 +814,7 @@ bool ConstStructBuilder::Build(const APValue &Val, const RecordDecl *RD,
       llvm::Constant *VTableAddressPoint =
           CGM.getCXXABI().getVTableAddressPoint(BaseSubobject(CD, Offset),
                                                 VTableClass);
-      if (auto Authentication =
-              CGM.getVTablePointerAuthentication(CD)) {
+      if (auto Authentication = CGM.getVTablePointerAuthentication(CD)) {
         VTableAddressPoint = Emitter.tryEmitConstantSignedPointer(
             VTableAddressPoint, *Authentication);
         if (!VTableAddressPoint)

``````````

</details>


https://github.com/llvm/llvm-project/pull/99741


More information about the cfe-commits mailing list