[clang] [clang][ARM64EC] Add support for hybrid_patchable attribute. (PR #99478)

Jacek Caban via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 19 03:05:39 PDT 2024


================
@@ -6886,6 +6886,13 @@ static void checkAttributesAfterMerging(Sema &S, NamedDecl &ND) {
     }
   }
 
+  if (HybridPatchableAttr *Attr = ND.getAttr<HybridPatchableAttr>()) {
+    if (!ND.isExternallyVisible()) {
+      S.Diag(Attr->getLocation(),
+             diag::warn_attribute_hybrid_patchable_non_extern);
+      ND.dropAttr<SelectAnyAttr>();
----------------
cjacek wrote:

Good point, it was a copoy&paste typo. Actually, we don't really need it as LLVM part ignores the attribute for static functions itself. I removed that line and left only diagnostics part here to slightly simplify the code.

https://github.com/llvm/llvm-project/pull/99478


More information about the cfe-commits mailing list