[clang] [clang] Emit bad shift warnings (PR #70307)

Alan Zhao via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 18 12:40:56 PDT 2024


alanzhao1 wrote:

> > @alanzhao1 do you think it's reasonable for the workaround to only apply to code in system headers, or does the NDK get included as regular headers generally?
> 
> Having it only apply to system headers should be OK - in our case, chrome imports these headers as part of a `--sysroot`, which IIRC treats warnings the same way as `-isystem`
> 
> > Do you need us to revert the changes while we resolve this?
> 
> If you can revert while working on a solution, that would be helpful.

We (Chrome) no longer need a revert - we patched the NDK locally.

https://github.com/llvm/llvm-project/pull/70307


More information about the cfe-commits mailing list