[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

Pavel Skripkin via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 18 00:31:02 PDT 2024


pskrgag wrote:

Thank you for review!

I've applied your suggestions and fixed test failures. Messed up a bit with shadowing in constructor. 

> Usually, GitHub PRs prefer "merges" over "force-pushes". Whenever you force-push, all the inline remarks could get lost, as it fails to track the lines where the comments were made

Oh, ok. I've never really worked with gh workflow, so didn't know that. Thank you for guidance!

https://github.com/llvm/llvm-project/pull/98941


More information about the cfe-commits mailing list