[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 16 06:02:14 PDT 2024


================
@@ -344,10 +352,17 @@ class ComplexExprEmitter
     return QualType();
   }
 
+  template <typename T>
+  FPOptionsOverride getStoredFPFeaturesOrDefault(const T *E,
+                                                 const CodeGenFunction &CGF) {
----------------
AaronBallman wrote:

`CGF` is unused, can it be removed?

Why a template type? Everything is passing in some subclass of `Expr` it seems.

Also, the function should be marked `static`, but why not add it as a member function alongside `getStoredFPFeatures()`?

https://github.com/llvm/llvm-project/pull/98520


More information about the cfe-commits mailing list