[clang] [PAC] Implement function pointer re-signing (PR #98847)

Daniil Kovalev via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 16 05:00:38 PDT 2024


================
@@ -4434,16 +4433,41 @@ class CodeGenFunction : public CodeGenTypeCache {
                                         llvm::Value *StorageAddress,
                                         GlobalDecl SchemaDecl,
                                         QualType SchemaType);
+
   llvm::Value *EmitPointerAuthSign(QualType PointeeType, llvm::Value *Pointer);
   llvm::Value *EmitPointerAuthSign(const CGPointerAuthInfo &Info,
                                    llvm::Value *Pointer);
+
+  llvm::Value *EmitPointerAuthAuth(QualType PointeeType, llvm::Value *Pointer);
----------------
kovdan01 wrote:

Several newly defined member functions look unused and unneeded in scope of this PR:
- `llvm::Value *CodeGenFunction::EmitPointerAuthAuth(QualType PointeeType, llvm::Value *Pointer)`
- `Address CodeGenFunction::EmitPointerAuthSign(Address Addr, QualType PointeeType)`
- `Address CodeGenFunction::EmitPointerAuthAuth(Address Addr, QualType PointeeType)`

I think it's better to remove them

https://github.com/llvm/llvm-project/pull/98847


More information about the cfe-commits mailing list