[clang] [NFC][clang] Replace unchecked dyn_cast with cast (PR #98948)
Mike Rice via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 15 12:42:38 PDT 2024
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/98948
BI__builtin_hlsl_elementwise_rcp is only invoked with a FixedVectorType so use cast to make this clear and satisfy the static verifier.
>From 68b271a07bea190e515fb24e1ec0a833624078bc Mon Sep 17 00:00:00 2001
From: Mike Rice <michael.p.rice at intel.com>
Date: Mon, 15 Jul 2024 11:40:17 -0700
Subject: [PATCH] [NFC][clang] Replace unchecked dyn_cast with cast
BI__builtin_hlsl_elementwise_rcp is only invoked with a FixedVectorType
so use cast to make this clear and satisfy the static verifier.
---
clang/lib/CodeGen/CGBuiltin.cpp | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp
index a54fa7bf87aad..c0297476391d2 100644
--- a/clang/lib/CodeGen/CGBuiltin.cpp
+++ b/clang/lib/CodeGen/CGBuiltin.cpp
@@ -18389,13 +18389,12 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned BuiltinID,
llvm_unreachable("rcp operand must have a float representation");
llvm::Type *Ty = Op0->getType();
llvm::Type *EltTy = Ty->getScalarType();
- Constant *One =
- Ty->isVectorTy()
- ? ConstantVector::getSplat(
- ElementCount::getFixed(
- dyn_cast<FixedVectorType>(Ty)->getNumElements()),
- ConstantFP::get(EltTy, 1.0))
- : ConstantFP::get(EltTy, 1.0);
+ Constant *One = Ty->isVectorTy()
+ ? ConstantVector::getSplat(
+ ElementCount::getFixed(
+ cast<FixedVectorType>(Ty)->getNumElements()),
+ ConstantFP::get(EltTy, 1.0))
+ : ConstantFP::get(EltTy, 1.0);
return Builder.CreateFDiv(One, Op0, "hlsl.rcp");
}
case Builtin::BI__builtin_hlsl_elementwise_rsqrt: {
More information about the cfe-commits
mailing list