[clang] [clang] Emit bad shift warnings (PR #70307)

[Stephan Bergmann via cfe-commits]

stbergmann wrote:

> That is intentional; `strlen` is not a valid constant expression in C, and so that is technically a VLA, except we have an extension to fold it back into a constant.

Thanks for confirming.  From the commit message and the changes to `clang/docs/ReleaseNotes.rst` it just didn't look like this newly emitted warning was intended by the commit.  But now I notice the changes to `clang/test/Sema/builtins.c` that do acknowledge this newly emitted warning.

https://github.com/llvm/llvm-project/pull/70307