[clang] [llvm] AMDGPU: Move attributor into optimization pipeline (PR #83131)

Sat Jul 13 22:01:11 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang,llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/1668

Here is the relevant piece of the build log for the reference:
```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/fuchsia-linux.py ...' (failure)
...
[1310/1312] Linking CXX executable tools/clang/unittests/Tooling/ToolingTests
[1311/1312] Running the Clang regression tests
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using clang: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/clang
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/subst.py:126: note: Did not find clang-repl in /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin:/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using ld.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/ld.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using lld-link: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/lld-link
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using ld64.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/ld64.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using wasm-ld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/wasm-ld
-- Testing: 20952 tests, 60 workers --
Testing:  0.. 10.. 20.. 30.. 40
FAIL: Clang :: CodeGenHIP/default-attributes.hip (9238 of 20952)
******************** TEST 'Clang :: CodeGenHIP/default-attributes.hip' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 2: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/clang -cc1 -internal-isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/lib/clang/19/include -nostdsysteminc -triple amdgcn-amd-amdhsa -x hip -fno-ident -fcuda-is-device     -emit-llvm -o - /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip | /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/FileCheck -check-prefix=OPTNONE /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/clang -cc1 -internal-isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/lib/clang/19/include -nostdsysteminc -triple amdgcn-amd-amdhsa -x hip -fno-ident -fcuda-is-device -emit-llvm -o - /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/FileCheck -check-prefix=OPTNONE /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip
RUN: at line 5: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/clang -cc1 -internal-isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/lib/clang/19/include -nostdsysteminc -O3 -triple amdgcn-amd-amdhsa -x hip -fno-ident -fcuda-is-device     -emit-llvm -o - /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip | /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/FileCheck -check-prefix=OPT /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/clang -cc1 -internal-isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/lib/clang/19/include -nostdsysteminc -O3 -triple amdgcn-amd-amdhsa -x hip -fno-ident -fcuda-is-device -emit-llvm -o - /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/FileCheck -check-prefix=OPT /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip:55:9: error: OPT: expected string not found in input
// OPT: attributes #[[ATTR0]] = { mustprogress nofree norecurse nosync nounwind willreturn memory(none) "amdgpu-no-agpr" "amdgpu-no-completion-action" "amdgpu-no-default-queue" "amdgpu-no-dispatch-id" "amdgpu-no-dispatch-ptr" "amdgpu-no-heap-ptr" "amdgpu-no-hostcall-ptr" "amdgpu-no-implicitarg-ptr" "amdgpu-no-lds-kernel-id" "amdgpu-no-multigrid-sync-arg" "amdgpu-no-queue-ptr" "amdgpu-no-workgroup-id-x" "amdgpu-no-workgroup-id-y" "amdgpu-no-workgroup-id-z" "amdgpu-no-workitem-id-x" "amdgpu-no-workitem-id-y" "amdgpu-no-workitem-id-z" "amdgpu-waves-per-eu"="4,10" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "uniform-work-group-size"="false" }
        ^
<stdin>:19:10: note: scanning from here
 ret void
         ^
<stdin>:19:10: note: with "ATTR0" equal to "0"
 ret void
         ^

Input file: <stdin>
Check file: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            .
            .
            .
           14: } 
           15:  
           16: ; Function Attrs: mustprogress nofree norecurse nosync nounwind willreturn memory(none) 
           17: define dso_local amdgpu_kernel void @_Z6kernelv() local_unnamed_addr #1 { 
           18: entry: 
           19:  ret void 
check:55'0              X error: no match found
Step 7 (check) failure: check (failure)
...
[1310/1312] Linking CXX executable tools/clang/unittests/Tooling/ToolingTests
[1311/1312] Running the Clang regression tests
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using clang: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/clang
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/subst.py:126: note: Did not find clang-repl in /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin:/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using ld.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/ld.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using lld-link: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/lld-link
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using ld64.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/ld64.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:508: note: using wasm-ld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/wasm-ld
-- Testing: 20952 tests, 60 workers --
Testing:  0.. 10.. 20.. 30.. 40
FAIL: Clang :: CodeGenHIP/default-attributes.hip (9238 of 20952)
******************** TEST 'Clang :: CodeGenHIP/default-attributes.hip' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 2: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/clang -cc1 -internal-isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/lib/clang/19/include -nostdsysteminc -triple amdgcn-amd-amdhsa -x hip -fno-ident -fcuda-is-device     -emit-llvm -o - /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip | /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/FileCheck -check-prefix=OPTNONE /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/clang -cc1 -internal-isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/lib/clang/19/include -nostdsysteminc -triple amdgcn-amd-amdhsa -x hip -fno-ident -fcuda-is-device -emit-llvm -o - /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/FileCheck -check-prefix=OPTNONE /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip
RUN: at line 5: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/clang -cc1 -internal-isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/lib/clang/19/include -nostdsysteminc -O3 -triple amdgcn-amd-amdhsa -x hip -fno-ident -fcuda-is-device     -emit-llvm -o - /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip | /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/FileCheck -check-prefix=OPT /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/clang -cc1 -internal-isystem /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/lib/clang/19/include -nostdsysteminc -O3 -triple amdgcn-amd-amdhsa -x hip -fno-ident -fcuda-is-device -emit-llvm -o - /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-_rzgovtk/bin/FileCheck -check-prefix=OPT /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip:55:9: error: OPT: expected string not found in input
// OPT: attributes #[[ATTR0]] = { mustprogress nofree norecurse nosync nounwind willreturn memory(none) "amdgpu-no-agpr" "amdgpu-no-completion-action" "amdgpu-no-default-queue" "amdgpu-no-dispatch-id" "amdgpu-no-dispatch-ptr" "amdgpu-no-heap-ptr" "amdgpu-no-hostcall-ptr" "amdgpu-no-implicitarg-ptr" "amdgpu-no-lds-kernel-id" "amdgpu-no-multigrid-sync-arg" "amdgpu-no-queue-ptr" "amdgpu-no-workgroup-id-x" "amdgpu-no-workgroup-id-y" "amdgpu-no-workgroup-id-z" "amdgpu-no-workitem-id-x" "amdgpu-no-workitem-id-y" "amdgpu-no-workitem-id-z" "amdgpu-waves-per-eu"="4,10" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "uniform-work-group-size"="false" }
        ^
<stdin>:19:10: note: scanning from here
 ret void
         ^
<stdin>:19:10: note: with "ATTR0" equal to "0"
 ret void
         ^

Input file: <stdin>
Check file: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/clang/test/CodeGenHIP/default-attributes.hip

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            .
            .
            .
           14: } 
           15:  
           16: ; Function Attrs: mustprogress nofree norecurse nosync nounwind willreturn memory(none) 
           17: define dso_local amdgpu_kernel void @_Z6kernelv() local_unnamed_addr #1 { 
           18: entry: 
           19:  ret void 
check:55'0              X error: no match found

```

https://github.com/llvm/llvm-project/pull/83131