[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

[Matheus Izvekov via cfe-commits]

mizvekov wrote:

> Clarifying a couple of things here

I think we need the distinction between simple NFC, for trivial, non-controversial and non-surprising changes like some renames, small whitespace / formatting change, documentation changes, and complex NFC, which requires some thinking and has more risk of not actually being NFC.

So in practical terms, I propose a complex NFC change should only be excused of changes to functional testing, nothing else.

Also, I think we presently have sufficient review bandwidth in clang proper, even including the area of modules, so that any non-trivial change can be reviewed, and I also propose that we abstain from trying to directly commit those.



https://github.com/llvm/llvm-project/pull/75912