[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)
Paul Kirth via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 12 08:04:15 PDT 2024
================
@@ -681,6 +683,7 @@ llvm::Error ClangDocBitcodeReader::readRecord(unsigned ID, Reference *I) {
// Read a block of records into a single info.
template <typename T>
llvm::Error ClangDocBitcodeReader::readBlock(unsigned ID, T I) {
+ llvm::TimeTraceScope("readBlock", "ClangDocBitcodeReader");
----------------
ilovepi wrote:
Have you looked at the profile with the new names? Is it easy to follow? I’d expect it’s a bit harder now, since you’ve dropped some info.
>From what I can see, the typical usage of the name is something like “parse input files”. Mostly within our tools we seem to try to capture how long some task is taking, e.g. parsing files, constructing the ast, generating call graphs, writing out files, etc.
I’d consider structuring these more around the tasks your tracking, and perhaps use the details to track more specific bits within a larger task or phase.
https://github.com/llvm/llvm-project/pull/97644
More information about the cfe-commits
mailing list