[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

Nikolas Klauser via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 10 09:18:51 PDT 2024


https://github.com/philnik777 commented:

> Sorry for the delay in review!

No worries! I dropped this for a few months myself. I can't expect to get a review within days when doing that :D

> This seems like the right direction to go, in general. As @erichkeane, it's a bit hard to review due to the whitespace-only changes and changes to `__is_trivially_equality_comparable`, you should remove those changes or split them into a separate PR.

Oops, looks like a commit got in here that was supposed to be part of another PR.

https://github.com/llvm/llvm-project/pull/70976


More information about the cfe-commits mailing list