[clang] [analyzer] Splitting TaintPropagation checker into reporting and mode… (PR #98157)

[Balazs Benics via cfe-commits]

================
@@ -1122,10 +1131,20 @@ void GenericTaintChecker::taintUnsafeSocketProtocol(const CallEvent &Call,
 }
 
 /// Checker registration
-void ento::registerGenericTaintChecker(CheckerManager &Mgr) {
+void ento::registerTaintPropagationChecker(CheckerManager &Mgr) {
   Mgr.registerChecker<GenericTaintChecker>();
 }
 
+bool ento::shouldRegisterTaintPropagationChecker(const CheckerManager &mgr) {
+  return true;
+}
+
+void ento::registerGenericTaintChecker(CheckerManager &Mgr) {
+  GenericTaintChecker *checker = Mgr.getChecker<GenericTaintChecker>();
+  checker->isTaintReporterCheckerEnabled = true;
+  checker->reporterCheckerName = Mgr.getCurrentCheckerName();
----------------
steakhal wrote:

I see. This is really unfortunate.
WDYT about hard-coding the checker name, as a string, and asserting that it's the same as the one in checkers td inside the register checker call, with a comment stating that you should also update the BugType accordingly.

https://github.com/llvm/llvm-project/pull/98157