[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)

Paul Kirth via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 9 18:07:08 PDT 2024


================
@@ -670,6 +671,7 @@ llvm::Error ClangDocBitcodeReader::readRecord(unsigned ID, T I) {
 
 template <>
 llvm::Error ClangDocBitcodeReader::readRecord(unsigned ID, Reference *I) {
+  llvm::TimeTraceScope("clang-doc", "readRecord Reference");
----------------
ilovepi wrote:

Why `readRecord Reference`? If you want to describe the fact that you're in `readRecord`, just do that, otherwise, if its a logical thing, `Read Record`. If `reference` is important, its fine to leave, but its not clear to me why. 

https://github.com/llvm/llvm-project/pull/97644


More information about the cfe-commits mailing list