[clang] [llvm] [AMDGPU] Report error in clang if wave32 is requested where unsupported (PR #97633)
Stanislav Mekhanoshin via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 8 13:08:23 PDT 2024
================
@@ -188,8 +188,12 @@ bool AMDGPUTargetInfo::initFeatureMap(
// TODO: Should move this logic into TargetParser
std::string ErrorMsg;
- if (!insertWaveSizeFeature(CPU, getTriple(), Features, ErrorMsg)) {
- Diags.Report(diag::err_invalid_feature_combination) << ErrorMsg;
+ bool IsCombinationError;
+ if (!insertWaveSizeFeature(CPU, getTriple(), Features, ErrorMsg,
----------------
rampitec wrote:
Ugh. Actually it would need to include clang header into the TargetParser.h. This is the primary reason the diagnostics was not moved there completely and the TODO comment 3 lines above.
https://github.com/llvm/llvm-project/pull/97633
More information about the cfe-commits
mailing list