[clang-tools-extra] [clang-tidy] Only expand <inttypes.h> macros in modernize-use-std-format/print (PR #97911)
Mike Crowe via cfe-commits
cfe-commits at lists.llvm.org
Sun Jul 7 08:17:18 PDT 2024
mikecrowe wrote:
It looks like the tests are failing on Windows because the `%s` in the command line
```
// RUN: %check_clang_tidy \
// RUN: -std=c++20 %s modernize-use-std-format %t -- \
// RUN: -config="{CheckOptions: {StrictMode: true}}" \
// RUN: -- -isystem %clang_tidy_headers \
// RUN: -DPRI_CMDLINE_MACRO="\"%s\"" \
// RUN: -D__PRI_CMDLINE_MACRO="\"%s\""
```
is being replaced by the filename for the LIT test:
```
| Running ['clang-tidy', 'C:\\ws\\src\\build\\tools\\clang\\tools\\extra\\test\\clang-tidy\\checkers\\modernize\\Output\\use-std-format.cpp.tmp.cpp', '-fix', '--checks=-*,modernize-use-std-format', '-config={CheckOptions: {StrictMode: true}}', '--', '-isystem', 'C:/ws/src/clang-tools-extra/test/../test\\clang-tidy\\checkers\\Inputs\\Headers', '-DPRI_CMDLINE_MACRO="C:\\ws\\src\\clang-tools-extra\\test\\clang-tidy\\checkers\\modernize\\use-std-format.cpp"', '-D__PRI_CMDLINE_MACRO="C:\\ws\\src\\clang-tools-extra\\test\\clang-tidy\\checkers\\modernize\\use-std-format.cpp"', '-std=c++20', '-nostdinc++']...
```
I can believe that this is being done by `TestRunner.py` (or some other part of llvm-lit) since that's expected for the first `%s` on the command line, but the surprise is that it doesn't also do this on Linux. Nevertheless, I'll modify the tests to avoid using `%` at all in the macros on the command line.
https://github.com/llvm/llvm-project/pull/97911
More information about the cfe-commits
mailing list