[clang] [Clang] Remove unnecessary copy (PR #97902)
via cfe-commits
cfe-commits at lists.llvm.org
Sat Jul 6 09:06:59 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: None (smanna12)
<details>
<summary>Changes</summary>
Reported by Static Analyzer Tool:
In clang::ASTNodeImporter::VisitCountAttributedType(clang::CountAttributedType const *): Using the auto keyword without an & causes the copy of an object of type TypeCoupledDeclRefInfo
---
Full diff: https://github.com/llvm/llvm-project/pull/97902.diff
1 Files Affected:
- (modified) clang/lib/AST/ASTImporter.cpp (+1-1)
``````````diff
diff --git a/clang/lib/AST/ASTImporter.cpp b/clang/lib/AST/ASTImporter.cpp
index 4e1b3a5a94de7..0c27f6f5df2da 100644
--- a/clang/lib/AST/ASTImporter.cpp
+++ b/clang/lib/AST/ASTImporter.cpp
@@ -1551,7 +1551,7 @@ ASTNodeImporter::VisitCountAttributedType(const CountAttributedType *T) {
Expr *CountExpr = importChecked(Err, T->getCountExpr());
SmallVector<TypeCoupledDeclRefInfo, 1> CoupledDecls;
- for (auto TI : T->dependent_decls()) {
+ for (const TypeCoupledDeclRefInfo &TI : T->dependent_decls()) {
Expected<ValueDecl *> ToDeclOrErr = import(TI.getDecl());
if (!ToDeclOrErr)
return ToDeclOrErr.takeError();
``````````
</details>
https://github.com/llvm/llvm-project/pull/97902
More information about the cfe-commits
mailing list