[clang] [Clang] Warn on backslash-newline-EOF (PR #97585)
via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 3 22:11:35 PDT 2024
================
@@ -3183,8 +3193,31 @@ bool Lexer::LexEndOfFile(Token &Result, const char *CurPtr) {
DiagID = diag::ext_no_newline_eof;
}
- Diag(BufferEnd, DiagID)
- << FixItHint::CreateInsertion(EndLoc, "\n");
+ if (LastNewline.empty()) {
+ Diag(BufferEnd, DiagID) << FixItHint::CreateInsertion(EndLoc, "\n");
+ } else {
+ // While the file physically ends in a newline, the previous
+ // line might have ended in a splice, so it would be deleted
+ const char *LastSpliceLocation = LastNewline.data();
+ while (LastSpliceLocation != BufferStart &&
+ isHorizontalWhitespace(*--LastSpliceLocation))
+ ;
----------------
Sirraide wrote:
On that note, we appear to be missing tests for when there is horizontal whitespace after a splice.
https://github.com/llvm/llvm-project/pull/97585
More information about the cfe-commits
mailing list