[clang] [llvm] Remove llvm/MC/MCAsmLayout.h and the unused parameter in MCAssembler::layout (PR #97449)

Fangrui Song via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 2 17:04:47 PDT 2024


MaskRay wrote:

> Thanks. RIP MCAsmLayout.

Thanks for the review!


> dcci: Thanks for putting this up for review. I appreciate you doing it, for this and future MC patches that could impact BOLT.

Just to clarify, these changes are fairly straightforward and shouldn't impact any clients.
(The extra "assert" was indeed a mistake on my part, and I apologize for mentioning it repeatedly. What I feel bad is that you did not seem to be aware of the issues caused by your reverts... At least I do not see a good justification)

On a separate note, regarding reverts, I understand the desire to keep BOLT maintainers informed of MC changes. 
Perhaps there's a way to achieve this goal without potentially causing unintended breakage through reverts.


https://github.com/llvm/llvm-project/pull/97449


More information about the cfe-commits mailing list