[clang] [clang-tools-extra] [clang-format] Aggregate options regarding empty lines (PR #96770)

Owen Pan via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 28 22:43:25 PDT 2024


owenca wrote:

> This patch was initially part of [9267f8f](https://github.com/llvm/llvm-project/commit/9267f8f19a2e502ef5a216c0d52b352b3699d399). I neglected to check the server builds before I added it. It broke clangd. Jie Fu fixed the problem in [4c91b49](https://github.com/llvm/llvm-project/commit/4c91b49bab0728d4bc136aa33c4aeb4e8ea37d01). I was unaware of it. I thought the main branch was still broken. I reverted the first patch in [70cfece](https://github.com/llvm/llvm-project/commit/70cfece24d6cbb57e35dd961cc97eb2a6bf1e387). It broke his fix. He reverted it in [c69ea04](https://github.com/llvm/llvm-project/commit/c69ea04fb9738db283263eb350669e00b77ee4fd).

Instead, can you reland 9267f8f19a2e502ef5a216c0d52b352b3699d399 with the 1-line change in 4c91b49bab0728d4bc136aa33c4aeb4e8ea37d01 so that we don't need to review it again?

https://github.com/llvm/llvm-project/pull/96770


More information about the cfe-commits mailing list