[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

Zequan Wu via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 28 10:19:39 PDT 2024


ZequanWu wrote:

I have a partially reduced repro:
```
$ clang++ "-cc1" "-triple" "arm64-apple-macosx10.15.0" "-Wundef-prefix=TARGET_OS_" "-Werror=undef-prefix" "-Wdeprecated-objc-isa-usage" "-Werror=deprecated-objc-isa-usage" "-emit-llvm-bc" "-flto=thin" "-flto-unit" "-disable-free" "-clear-ast-before-backend" "-main-file-name" "rtp_transmission_manager.cc" "-mrelocation-model" "pic" "-pic-level" "2" "-fmerge-all-constants" "-fno-delete-null-pointer-checks" "-mframe-pointer=non-leaf" "-relaxed-aliasing" "-ffp-contract=off" "-fno-rounding-math" "-target-sdk-version=14.0" "-fcompatibility-qualified-id-block-type-checking" "-fvisibility-inlines-hidden-static-local-var" "-fbuiltin-headers-in-system-modules" "-fdefine-target-os-macros" "-target-cpu" "apple-m1" "-target-feature" "+zcm" "-target-feature" "+zcz" "-target-feature" "+v8.4a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+dotprod" "-target-feature" "+complxnum" "-target-feature" "+fp-armv8" "-target-feature" "+fullfp16" "-target-feature" "+fp16fml" "-target-feature" "+jsconv" "-target-feature" "+lse" "-target-feature" "+pauth" "-target-feature" "+perfmon" "-target-feature" "+predres" "-target-feature" "+ras" "-target-feature" "+rcpc" "-target-feature" "+rdm" "-target-feature" "+sb" "-target-feature" "+sha2" "-target-feature" "+sha3" "-target-feature" "+neon" "-target-feature" "+ssbs" "-target-abi" "darwinpcs" "-debug-info-kind=constructor" "-dwarf-version=4" "-debugger-tuning=lldb" "-mllvm" "-generate-arange-section" "-fdebug-compilation-dir=/Volumes/Work/s/w/ir/cache/builder/src/out/Release" "-target-linker-version" "1053.12"  "-fcoverage-compilation-dir=/Volumes/Work/s/w/ir/cache/builder/src/out/Release" "-nostdinc++" "-D" "OFFICIAL_BUILD" "-D" "__STDC_CONSTANT_MACROS" "-D" "__STDC_FORMAT_MACROS" "-D" "_FORTIFY_SOURCE=2" "-D" "_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE" "-D" "__ARM_NEON__=1" "-D" "CR_XCODE_VERSION=1500" "-D" "CR_CLANG_REVISION=\"llvmorg-19-init-15776-ge48c4011-0\"" "-D" "_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS" "-D" "_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS" "-D" "CR_LIBCXX_REVISION=09b99fd8ab300c93ff7b8df6688cafb27bd3db28" "-D" "NDEBUG" "-D" "NVALGRIND" "-D" "DYNAMIC_ANNOTATIONS_ENABLED=0" "-D" "WEBRTC_ENABLE_PROTOBUF=1" "-D" "WEBRTC_STRICT_FIELD_TRIALS=0" "-D" "RTC_ENABLE_VP9" "-D" "RTC_ENABLE_H265" "-D" "RTC_DAV1D_IN_INTERNAL_DECODER_FACTORY" "-D" "WEBRTC_HAVE_SCTP" "-D" "ENABLE_EXTERNAL_AUTH" "-D" "WEBRTC_USE_H264" "-D" "HAVE_WEBRTC_VIDEO" "-D" "LOGGING_INSIDE_WEBRTC" "-D" "WEBRTC_ARCH_ARM64" "-D" "WEBRTC_HAS_NEON" "-D" "RTC_USE_PERFETTO" "-D" "WEBRTC_LIBRARY_IMPL" "-D" "WEBRTC_ENABLE_AVX2" "-D" "WEBRTC_CHROMIUM_BUILD" "-D" "WEBRTC_POSIX" "-D" "WEBRTC_MAC" "-D" "ABSL_ALLOCATOR_NOTHROW=1" "-D" "LIBYUV_DISABLE_LSX" "-D" "LIBYUV_DISABLE_LASX" "-D" "UNSAFE_BUFFERS_BUILD" "-D" "PROTOBUF_ALLOW_DEPRECATED=1" "-O2" "-Wall" "-Wextra" "-Wimplicit-fallthrough" "-Wextra-semi" "-Wunreachable-code-aggressive" "-Wthread-safety" "-Wunguarded-availability" "-Wno-missing-field-initializers" "-Wno-unused-parameter" "-Wno-psabi" "-Wloop-analysis" "-Wno-unneeded-internal-declaration" "-Wno-cast-function-type" "-Wno-ignored-pragma-optimize" "-Wno-deprecated-builtins" "-Wno-deprecated-this-capture" "-Wno-invalid-offsetof" "-Wno-vla-extension" "-Wno-thread-safety-reference-return" "-Wshadow" "-Werror" "-Wno-profile-instr-unprofiled" "-Wno-profile-instr-out-of-date" "-Wno-backend-plugin" "-Wheader-hygiene" "-Wstring-conversion" "-Wtautological-overlap-compare" "-Wexit-time-destructors" "-Wglobal-constructors" "-Wno-shadow" "-Wctad-maybe-unsupported" "-Wenum-compare-conditional" "-Wno-c++11-narrowing-const-reference" "-Wno-missing-template-arg-list-after-template-kw" "-Wno-trigraphs" "-std=c++20" "-fdeprecated-macro" "-ferror-limit" "19" "-fvisibility=hidden" "-fvisibility-inlines-hidden" "-stack-protector" "1" "-ftrivial-auto-var-init=pattern" "-fblocks" "-fencode-extended-block-signature" "-fno-rtti" "-fregister-global-dtors-with-atexit" "-fgnuc-version=4.2.1" "-fno-implicit-modules" "-fskip-odr-check-in-gmf" "-fno-sized-deallocation" "-fmax-type-align=16" "-Qn" "-fcolor-diagnostics" "-vectorize-loops" "-vectorize-slp" "-debug-info-kind=limited" "-D__GCC_HAVE_DWARF2_CFI_ASM=1" "-x" "c++" rtp_transmission_manager.cpp
```
I have to rename the attached file to `*.txt` as github doesn't allow .cpp suffix.
[rtp_transmission_manager.txt](https://github.com/user-attachments/files/16033951/rtp_transmission_manager.txt)


https://github.com/llvm/llvm-project/pull/93113


More information about the cfe-commits mailing list