[clang] [clang] Implement function pointer type discrimination (PR #96992)

Daniil Kovalev via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 28 08:14:25 PDT 2024


================
@@ -5,55 +5,65 @@
 // RUN:   -fptrauth-vtable-pointer-address-discrimination \
 // RUN:   -fptrauth-vtable-pointer-type-discrimination \
 // RUN:   -fptrauth-init-fini | \
-// RUN:   FileCheck %s --check-prefixes=INTRIN,CALLS,RETS,VPTR_ADDR_DISCR,VPTR_TYPE_DISCR,INITFINI
+// RUN:   FileCheck %s --check-prefixes=INTRIN,CALLS,RETS,VPTR_ADDR_DISCR,VPTR_TYPE_DISCR,INITFINI,NOFUNC
----------------
kovdan01 wrote:

Nit: we have test cases for everything enabled and for everything-except-one-feature enabled, so, to keep things consistent, it's probably better to have `-fptrauth-function-pointer-type-discrimination` passed for all test cases except one. Alternatively, we can test nothing-enabled-except-one-feature, it'll result in more compact RUN lines.

Current variant is also OK in terms of testing that things work properly, so I don't mind leaving this "as is".

https://github.com/llvm/llvm-project/pull/96992


More information about the cfe-commits mailing list