[clang] [llvm] [polly] [IR] Don't include Module.h in Analysis.h (NFC) (PR #97023)

Fri Jun 28 05:42:23 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `ml-opt-dev-x86-64` running on `ml-opt-dev-x86-64-b2` while building `clang,llvm,polly` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/137/builds/829

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
33.359 [2882/64/672] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/DebugLoc.cpp.o
33.414 [2881/64/673] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ExpandPostRAPseudos.cpp.o
34.097 [2880/64/674] Building CXX object examples/IRTransforms/CMakeFiles/ExampleIRTransforms.dir/SimplifyCFG.cpp.o
34.454 [2879/64/675] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/PassManager.cpp.o
34.504 [2878/64/676] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/FaultMaps.cpp.o
34.556 [2877/64/677] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/FEntryInserter.cpp.o
35.882 [2876/64/678] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/ConvergenceVerifier.cpp.o
35.966 [2875/64/679] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/FixupStatepointCallerSaved.cpp.o
36.028 [2874/64/680] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/FuncletLayout.cpp.o
36.876 [2873/64/681] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MLRegAllocPriorityAdvisor.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MLRegAllocPriorityAdvisor.cpp.o 
ccache /usr/bin/c++ -DCPUINFO_SUPPORTED_PLATFORM=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/ml-opt-dev-x86-64-b1/build/lib/CodeGen -I/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/CodeGen -I/b/ml-opt-dev-x86-64-b1/build/include -I/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include -isystem /tmp/tflitebuild/tensorflow/include -isystem /tmp/tflitebuild/eigen/include/eigen3 -isystem /tmp/tflitebuild/abseil-cpp/include -isystem /tmp/tflitebuild/flatbuffers/include -isystem /tmp/tflitebuild/gemmlowp/include/gemmlowp -isystem /tmp/tflitebuild/ml_dtypes/src/ml_dtypes -isystem /tmp/tflitebuild/ml_dtypes/src/ml_dtypes/ml_dtypes -isystem /tmp/tflitebuild/ruy/include -isystem /tmp/tflitebuild/cpuinfo/include -isystem /tmp/tflitebuild/ARM_NEON_2_x86_SSE/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -DEIGEN_NEON_GEBP_NR=4 -DTFL_STATIC_LIBRARY_BUILD -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MLRegAllocPriorityAdvisor.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MLRegAllocPriorityAdvisor.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MLRegAllocPriorityAdvisor.cpp.o -c /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/CodeGen/MLRegAllocPriorityAdvisor.cpp
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/CodeGen/MLRegAllocPriorityAdvisor.cpp: In member function ‘virtual bool llvm::DevelopmentModePriorityAdvisorAnalysis::doInitialization(llvm::Module&)’:
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/CodeGen/MLRegAllocPriorityAdvisor.cpp:223:24: error: invalid use of incomplete type ‘class llvm::Module’
  223 |     LLVMContext &Ctx = M.getContext();
      |                        ^
In file included from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/IR/User.h:24,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/IR/Constant.h:16,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/IR/Metadata.h:26,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/Analysis/MemoryLocation.h:19,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/MachineInstr.h:23,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/MachineBasicBlock.h:20,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/SlotIndexes.h:26,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/LiveInterval.h:29,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/CodeGen/InterferenceCache.h:18,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/CodeGen/RegAllocGreedy.h:15,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/CodeGen/MLRegAllocPriorityAdvisor.cpp:14:
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/IR/Value.h:47:7: note: forward declaration of ‘class llvm::Module’
   47 | class Module;
      |       ^~~~~~
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/CodeGen/MLRegAllocPriorityAdvisor.cpp:243:7: error: invalid use of incomplete type ‘class llvm::Module’
  243 |       M.getContext().emitError(EC.message() + ":" + TrainingLog);
      |       ^
In file included from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/IR/User.h:24,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/IR/Constant.h:16,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/IR/Metadata.h:26,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/Analysis/MemoryLocation.h:19,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/MachineInstr.h:23,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/MachineBasicBlock.h:20,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/SlotIndexes.h:26,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/LiveInterval.h:29,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/CodeGen/InterferenceCache.h:18,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/CodeGen/RegAllocGreedy.h:15,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/CodeGen/MLRegAllocPriorityAdvisor.cpp:14:
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/IR/Value.h:47:7: note: forward declaration of ‘class llvm::Module’
   47 | class Module;
      |       ^~~~~~
37.219 [2873/63/682] Building X86GenSubtargetInfo.inc...
38.035 [2873/62/683] Building CXX object lib/FuzzMutate/CMakeFiles/LLVMFuzzMutate.dir/RandomIRBuilder.cpp.o

```

https://github.com/llvm/llvm-project/pull/97023