[clang-tools-extra] 7878d9c - [clangd] Replace an include with a forward declaration

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 28 04:38:54 PDT 2024


Author: Nico Weber
Date: 2024-06-28T13:38:14+02:00
New Revision: 7878d9c0363528c44effe55aae2843fbabb6dd0e

URL: https://github.com/llvm/llvm-project/commit/7878d9c0363528c44effe55aae2843fbabb6dd0e
DIFF: https://github.com/llvm/llvm-project/commit/7878d9c0363528c44effe55aae2843fbabb6dd0e.diff

LOG: [clangd] Replace an include with a forward declaration

The real Client.cpp and other users of Client.h (ClangdMain.cpp, Dexp.cpp)
already include index/Index.h, so no effect there.

And UnimplementedClient.cpp only returns `nullptr` and doesn't need
to know the full type.

Makes it possible to compile UnimplementedClient.cpp without having
to wait for clang's tblgen code generators.

No behavior change.

Added: 
    

Modified: 
    clang-tools-extra/clangd/index/remote/Client.h

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/index/remote/Client.h b/clang-tools-extra/clangd/index/remote/Client.h
index ff5348bd23279..2fdcf7723d5be 100644
--- a/clang-tools-extra/clangd/index/remote/Client.h
+++ b/clang-tools-extra/clangd/index/remote/Client.h
@@ -9,11 +9,13 @@
 #ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_INDEX_REMOTE_CLIENT_H
 #define LLVM_CLANG_TOOLS_EXTRA_CLANGD_INDEX_REMOTE_CLIENT_H
 
-#include "index/Index.h"
 #include "llvm/ADT/StringRef.h"
 
 namespace clang {
 namespace clangd {
+
+class SymbolIndex;
+
 namespace remote {
 
 /// Returns an SymbolIndex client that passes requests to remote index located


        


More information about the cfe-commits mailing list