[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)
Alex Voicu via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 27 13:45:07 PDT 2024
================
@@ -270,5 +270,5 @@
// VE: target datalayout = "e-m:e-i64:64-n32:64-S128-v64:64:64-v128:64:64-v256:64:64-v512:64:64-v1024:64:64-v2048:64:64-v4096:64:64-v8192:64:64-v16384:64:64"
// RUN: %clang_cc1 -triple spirv64-amd -o - -emit-llvm %s | \
-// RUN: FileCheck %s -check-prefix=SPIR64
-// AMDGPUSPIRV64: target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-G1-P4-A0"
+// RUN: FileCheck %s -check-prefix=AMDGPUSPIRV64
+// AMDGPUSPIRV64: target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-G1"
----------------
AlexVlx wrote:
This change is incorrect, the DataLayout differs and we do encode both the Program AS and the alloca AS, please see <https://github.com/llvm/llvm-project/blob/f14ad74478494cbd9d23af841d6f6b2808afda71/clang/lib/Basic/Targets/SPIR.h#L384>, and please don't do this.
https://github.com/llvm/llvm-project/pull/96962
More information about the cfe-commits
mailing list