[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

[Aaron Ballman via cfe-commits]

================
@@ -7623,6 +7623,7 @@ handleNonBlockingNonAllocatingTypeAttr(TypeProcessingState &TPState,
   FunctionEffectSet FX(EPI.FunctionEffects);
   FunctionEffectSet::Conflicts Errs;
   bool Success = FX.insert(NewEC, Errs);
+  (void)Success;
----------------
AaronBallman wrote:

A better way to do this would be `[[maybe_unused]]` on the declaration instead of a cast to void.

https://github.com/llvm/llvm-project/pull/96844