[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

[Paul Kirth via cfe-commits]

================
@@ -34,13 +43,26 @@ template <typename T> bool MapASTVisitor::mapDecl(const T *D) {
   // If there is an error generating a USR for the decl, skip this decl.
   if (index::generateUSRForDecl(D, USR))
     return true;
+
+  // Prevent Visiting USR twice
+  {
+    std::lock_guard<llvm::sys::Mutex> Guard(USRVisitedGuard);
+    std::string Visited = USR.str().str();
----------------
ilovepi wrote:

Moreover, can we just construct a single owned string, and use a ‘StringRef’ to handle the rest of the operations? We may need to refactor some of the code slightly, but I think that should be possible. 

https://github.com/llvm/llvm-project/pull/96809