[clang] [clang][NFC] Use range-based for loops (PR #96831)

Vlad Serebrennikov via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 27 03:38:30 PDT 2024


================
@@ -2056,40 +2056,40 @@ void CXXRecordDecl::completeDefinition() {
   completeDefinition(nullptr);
 }
 
+static bool hasPureVirtualFinalOverrider(
+    const CXXRecordDecl &RD, const CXXFinalOverriderMap *FinalOverriders) {
+  auto ExistsIn = [](const CXXFinalOverriderMap &FinalOverriders) {
+    for (const auto &[_, M] : FinalOverriders) {
+      for (const auto &[_, SO] : M) {
----------------
Endilll wrote:

While we're at it, can we use more descriptive names than `M` and `SO`? I'm not even sure what the latter means. I also have reservations towards `auto` here.

https://github.com/llvm/llvm-project/pull/96831


More information about the cfe-commits mailing list