[clang-tools-extra] Attempt to fix issue 96247 (PR #96856)

via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 26 23:12:57 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang-tools-extra

Author: cqwrteur (trcrsired)

<details>
<summary>Changes</summary>

https://github.com/llvm/llvm-project/issues/96247

These libraries are not linked for windows gnu targets since the libraries are not linked. I need to find out what's going on here. But first, I will just run CI to see whether anything breaks. I guess the CMakeListst.txt File is just wrong by not linking. However, it looks weird it is only an issue on windows-gnu target since other targets should have the same issue, right?

---
Full diff: https://github.com/llvm/llvm-project/pull/96856.diff


1 Files Affected:

- (modified) clang-tools-extra/test/CMakeLists.txt (+6) 


``````````diff
diff --git a/clang-tools-extra/test/CMakeLists.txt b/clang-tools-extra/test/CMakeLists.txt
index 0953ff2531e1a..763ce8f967852 100644
--- a/clang-tools-extra/test/CMakeLists.txt
+++ b/clang-tools-extra/test/CMakeLists.txt
@@ -70,6 +70,12 @@ endforeach()
 if (NOT WIN32 OR NOT LLVM_LINK_LLVM_DYLIB)
   llvm_add_library(
       CTTestTidyModule
+      LINK_LIBS
+      clangAST
+      clangASTMatchers
+      clangTooling
+      clangBasic
+      clangTidy
       MODULE clang-tidy/CTTestTidyModule.cpp
       PLUGIN_TOOL clang-tidy)
 endif()

``````````

</details>


https://github.com/llvm/llvm-project/pull/96856


More information about the cfe-commits mailing list