[clang] [Clang] Access tls_guard via llvm.threadlocal.address (PR #96633)
John McCall via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 26 12:42:11 PDT 2024
================
@@ -1059,9 +1059,15 @@ CodeGenFunction::GenerateCXXGlobalInitFunc(llvm::Function *Fn,
if (Guard.isValid()) {
// If we have a guard variable, check whether we've already performed
// these initializations. This happens for TLS initialization functions.
- llvm::Value *GuardVal = Builder.CreateLoad(Guard);
- llvm::Value *Uninit = Builder.CreateIsNull(GuardVal,
- "guard.uninitialized");
+ Address GuardAddr = Guard;
+ if (auto *GV = dyn_cast<llvm::GlobalValue>(Guard.getPointer()))
----------------
rjmccall wrote:
We need to do this unconditionally, and we should be able to do because `Guard` is a constant address. But if there's some code pattern where that's not true, we need to fix that code pattern rather than silently just not using this intrinsic.
https://github.com/llvm/llvm-project/pull/96633
More information about the cfe-commits
mailing list